Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prex dec integration into master #914

Merged
merged 51 commits into from Dec 7, 2020
Merged

Prex dec integration into master #914

merged 51 commits into from Dec 7, 2020

Conversation

erikmarr
Copy link
Contributor

@erikmarr erikmarr commented Dec 7, 2020

Purpose of this pull request

This pull request (PR) integrates the Product Recommendations December release into Master

Magento release version

  • 2.4.x

    Specify a patch release number, if applicable:

  • 2.3.x

    Specify a patch release number, if applicable:

Product editions

Is this update specific to a product edition?

  • Magento Open Source only
  • Magento Commerce only

Is this update specific to an installed feature extension

  • B2B extension
  • Other feature set, please specify:

Affected documentation pages

  • Many pages under the Marketing>Promotions>Product Recommendations section

erikmarr and others added 30 commits August 26, 2020 13:27
Adding Visual similarity rec and reorganizing types
Co-authored-by: Misha <misha.kotov@gmail.com>
Updating content about using visual recs in testing environment
Co-authored-by: Misha <misha.kotov@gmail.com>
fixing linting errors.
Co-authored-by: Misha <misha.kotov@gmail.com>
Co-authored-by: Leslie Tilling <leslietilling@users.noreply.github.com>
removing indent
Co-authored-by: Leslie Tilling <leslietilling@users.noreply.github.com>
Adding Content for Inclusion and Exclusion Rules
@m2-community-project m2-community-project bot added this to Ready for Review in Pull Request Progress Dec 7, 2020
@erikmarr erikmarr self-assigned this Dec 7, 2020
@m2-community-project m2-community-project bot moved this from Ready for Review to Review in Progress in Pull Request Progress Dec 7, 2020
@erikmarr erikmarr added 2.4.x Changes for the Core 2.4.x release line, not patch specific Stakeholder Apply this label to PRs for Adobe employees that are not on the doc team labels Dec 7, 2020
erikmarr and others added 2 commits December 7, 2020 15:26
Copy link
Contributor

@leslietilling leslietilling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add "What's New" info. Might be better to manually update the list for this release rather than running through automation. That can be a separate PR if needed.

@m2-community-project m2-community-project bot moved this from Review in Progress to Reviewer Approved in Pull Request Progress Dec 7, 2020
@erikmarr
Copy link
Contributor Author

erikmarr commented Dec 7, 2020

running tests

@erikmarr erikmarr merged commit 813c597 into master Dec 7, 2020
@erikmarr erikmarr deleted the prex-dec-integration branch December 7, 2020 22:24
@m2-community-project m2-community-project bot moved this from Reviewer Approved to Done in Pull Request Progress Dec 7, 2020
@leslietilling leslietilling added P-rex and removed Stakeholder Apply this label to PRs for Adobe employees that are not on the doc team labels Feb 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.4.x Changes for the Core 2.4.x release line, not patch specific P-rex Progress: done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants