Add fallback images from configurable product if child products have no images. #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
singhramanpreett
suggested changes
Dec 1, 2023
There was a problem hiding this comment.
Hi @Bashev,
Thanks for making these changes.
I think we should fall back to parent images in case no images are present for child product in ProductRepository class's loadParentProductData function, as we are doing fallback to parent product's values for other fields as well in this class. Would be better to keep all fallback logic as same place.
|
@magento run all tests |
…duct-to-childs' into add-images-from-configurable-product-to-childs
…ages-from-configurable-product-to-childs # Conflicts: # app/code/Meta/Catalog/Model/ProductRepository.php
|
Seems to be fixed already with commit f3fb4c2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the time when we are using configurable products with children which have no differences in images (like size, length or similar) different image is not required, but need to be send to FB.
The PR add (as fallback) parent product images to child products which have no their own images.
Description (*)
Story
Bug
Task
Fixed Issues (if relevant)
Manual testing scenarios (*)
Questions or comments
Checklist