Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUNDLE-2833 (Vertex & Free Shipping calculated based on subtotal + tax) #43

Closed
wants to merge 1 commit into from
Closed

BUNDLE-2833 (Vertex & Free Shipping calculated based on subtotal + tax) #43

wants to merge 1 commit into from

Conversation

navarr
Copy link
Member

@navarr navarr commented Nov 12, 2020

Description

This patch resolves an issue where Free Shipping does not consider the tax on the order when determining whether or not it can apply (when configured to consider tax)

Fixed Issues (if relevant)

  1. BUNDLE-2833

@viktym
Copy link
Contributor

viktym commented Nov 19, 2020

@magento-engcom-team
Copy link
Contributor

@viktym the pull request successfully imported.

@navarr
Copy link
Member Author

navarr commented Nov 24, 2020

Closing as it looks like it was merged successfully through another process

@navarr navarr closed this Nov 24, 2020
@magento-cloud-ft-jenkins-svc

Unit Test Results

✅  All unit tests have passed.

Unit Test Output

> phpunit --configuration ./tests/integrity '--log-junit' 'tests/unit/tmp/junit.xml'
PHPUnit 6.5.14 by Sebastian Bergmann and contributors.

....                                                                4 / 4 (100%)

Time: 36 ms, Memory: 6.00MB

OK (4 tests, 0 assertions)

This comment was generated by Jenkins job magento-quality-patches/integrity build 15.

magento-cicd2 pushed a commit that referenced this pull request Jul 19, 2021
* Add categories configuration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants