Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow use reCAPTCHA globally #288

Closed
thomas-kl1 opened this issue Feb 3, 2021 · 6 comments
Closed

Allow use reCAPTCHA globally #288

thomas-kl1 opened this issue Feb 3, 2021 · 6 comments

Comments

@thomas-kl1
Copy link
Member

thomas-kl1 commented Feb 3, 2021

Description (*)

As a merchant I want to select the captcha domain:

See Google Documentation: https://developers.google.com/recaptcha/docs/faq#can-i-use-recaptcha-globally

Expected behavior (*)

Allow to use reCaptcha even in countries were google is known to be limited.

Benefits

Could be used by any merchant worldwide.

Additional information

I would like to work on this, please point me to the correct direction to:

  • Add the settings (adminhtml ui right?)
  • Add the setting to api (what package)?
  • Update the following files to use the alternative domain:
    • Magento/ReCaptchaFrontendUi/view/web/js/reCaptchaScriptLoader.js
    • Magento/ReCaptchaUser/view/adminhtml/templates/recaptcha.phtml

#289

@m2-assistant
Copy link

m2-assistant bot commented Feb 3, 2021

Hi @thomas-kl1. Thank you for your report.
To help us process this issue please make sure that you provided sufficient information.

Please, add a comment to assign the issue: @magento I am working on this


@m2-community-project m2-community-project bot added this to Ready for Grooming in Backlog Feb 3, 2021
thomas-kl1 added a commit to thomas-kl1/security-package that referenced this issue Feb 3, 2021
@thomas-kl1
Copy link
Member Author

@magento I am working on this

@thomas-kl1
Copy link
Member Author

thomas-kl1 commented Jul 26, 2021

@nathanjosiah do not mark this issue as "Progress: done" as the feature as not been implemented. Please re-open it

@nathanjosiah
Copy link
Contributor

@thomas-kl1 The labels are changed from our automation. I don't have fine control over them. I will re-open

@nathanjosiah nathanjosiah reopened this Jul 27, 2021
@m2-community-project m2-community-project bot moved this from Done to Pull Request In Progress in Backlog Jul 27, 2021
@m2-community-project m2-community-project bot moved this from Pull Request In Progress to Ready for Development in Backlog Sep 10, 2021
@m2-community-project m2-community-project bot moved this from Pull Request In Progress to Ready for Development in Backlog Sep 10, 2021
@nathanjosiah
Copy link
Contributor

Closing all non-active issues. This has been open and not really worked on for 213 days. We are not going to work on this internally but if you want to commit to working on it and stabilizing your PR I will reopen.

@m2-community-project m2-community-project bot moved this from Ready for Development to Done in Backlog Sep 10, 2021
@thomas-kl1 thomas-kl1 changed the title Allow use reCAPTCHA gloabally Allow use reCAPTCHA globally Sep 10, 2021
@thomas-kl1
Copy link
Member Author

@nathanjosiah maybe you could change the label, it's confusing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Backlog
  
Done
Development

No branches or pull requests

2 participants