Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dependency magento/module-notifier-admin-ui on magento/module-notifier #56

Closed
naydav opened this issue Jan 30, 2020 · 0 comments
Closed

Remove dependency magento/module-notifier-admin-ui on magento/module-notifier #56

naydav opened this issue Jan 30, 2020 · 0 comments
Assignees
@engcom-Kilo
Labels
Component: Notifier Progress: done
Projects
Backlog

Comments

@naydav
Copy link
Contributor

naydav commented Jan 30, 2020

Current dependency:

<virtualType name="Magento\NotifierAdminUi\Model\ResourceModel\UI\Channel\Collection"
                 type="Magento\Framework\View\Element\UiComponent\DataProvider\SearchResult">
        <arguments>
            <argument name="mainTable" xsi:type="string">notifier_channel</argument>
            <argument name="resourceModel"
                      xsi:type="string">Magento\Notifier\Model\ResourceModel\Channel\Collection</argument>
        </arguments>
    </virtualType>

Need to replace Magento\Notifier\Model\ResourceModel\Channel\Collection dependency on \Magento\NotifierApi\Api\ChannelRepositoryInterface

Example how to reflect current code:
https://github.com/naydav/Magento2Samples/blob/2.3/app/code/Engine/Location/view/adminhtml/ui_component/engine_location_city_form.xml#L36
https://github.com/naydav/Magento2Samples/blob/2.3/app/code/Engine/Location/Ui/DataProvider/CityDataProvider.php#L22
@m2-community-project m2-community-project bot added this to Ready for Grooming in Backlog Jan 30, 2020
@naydav naydav moved this from Ready for Grooming to Good First Issue in Backlog Jan 30, 2020
@m2-community-project m2-community-project bot added the Progress: good first issue Good for newcomers label Jan 30, 2020
@naydav naydav removed the Progress: good first issue Good for newcomers label Jan 30, 2020
@naydav naydav moved this from Good First Issue to Ready for Development in Backlog Jan 30, 2020
@engcom-Kilo engcom-Kilo self-assigned this Feb 28, 2020
@m2-community-project m2-community-project bot moved this from Ready for Development to Dev In Progress in Backlog Feb 28, 2020
@engcom-Kilo engcom-Kilo mentioned this issue Mar 11, 2020
Closed
5 tasks
@m2-community-project m2-community-project bot moved this from Dev In Progress to Pull Request In Progress in Backlog Mar 11, 2020
@sdzhepa sdzhepa linked a pull request Apr 14, 2020 that will close this issue
Remove dependency magento/module-notifier-admin-ui on magento/module-notifier #134
Closed
5 tasks
@m2-community-project m2-community-project bot moved this from Pull Request In Progress to Done in Backlog May 27, 2021
magento-devops-reposync-svc pushed a commit that referenced this issue Oct 22, 2021
@krissyhiserote
Merge pull request #56 from magento-trigger/AC-1445
543bd2d 
[Trigger] AC-1445: Unable to click Underline in TinyMCE on PageBuilder
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@engcom-Kilo engcom-Kilo

Labels
Component: Notifier Progress: done
Projects
Backlog
  
Done
Milestone
No milestone
3 participants
@naydav @nathanjosiah @engcom-Kilo