Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAGETWO-60033 : FIM (Markka) removed from currency #14

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

SubrataBauri
Copy link

  • Finland has moved to EUR in 2001

Relevant issue in Magento 2 repo:
magento/magento2#6832

- Finland has moved to EUR in 2001
@magento-cicd2
Copy link

magento-cicd2 commented May 19, 2018

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

@ArjenMiedema
Copy link

@SubrataBauri I think that if we remove the deprecated Finnish currency, we should also remove all other deprecated currencies. For example all other European currencies that were used before the Euro are still in this list. Talking about the German Mark, French Franc, Spanish Peseta, etc. These currencies are deprecated since 2002.

I think other currencies have been deprecated in the past decades as well, but I'm not aware which currencies those are. But I think cleaning up this list with more then just one currency is useful. Not sure if you have the time, but it would be great if you can do this.

@SubrataBauri
Copy link
Author

@ArjenMiedema can you provide the list of all the deprecated currencies? I can find time to clean them up.

@ArjenMiedema
Copy link

@SubrataBauri I don't know all deprecated currencies. All I know is that back in 2002 the Finnish Markka has been replaced by the Euro. The same goes for the old currencies for the following European countries:

  • Germany
  • Ireland
  • The Netherlands
  • Greece
  • France
  • Luxembourg
  • Austria
  • Belgium
  • Italy
  • Portugal
  • Spain

So those currencies can also be related. Big change is that there are more non-European currencies that are deprecated, but I don't know those.

@froschdesign
Copy link

All these XML files come from the external library "CLDR - Unicode Common Locale Data Repository" and you should not modify these files. You need to use a newer version of this library, but this ends up in a dead end:

CLDR v25 is the latest version for ZF1. Newer versions of CLDR means refactoring the Zend_Date class.

zendframework#436

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants