fix(oauth): sort parameters in a standard way as per the specs #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the signature is now calculated a bit differently to match other implementations. BREAKING CHANGE: existing OAuth applications may encounter some issues leading to `invalid_signature` 401 errors from Magento due to the removal of natural sorting for parameters when generating the signature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is similar to OpenMage/magento-lts#721
Please read the full description there.
TL;DR
Parameters must be "sorted by name, using lexicographical byte value ordering" (from Oauth specs) which is incorrect if using
strnatcmp.Magento is not able to validate signatures for requests with parameters such as
/rest/V1/foo?keys[0]=test1&keys[1]=test2&keys[2]=test3&keys[3]=test4&keys[4]=test5&keys[5]=test6&keys[6]=test7&keys[7]=test8&keys[8]=test9&keys[9]=test10&keys[10]=test11as it will consider thatkeys[10]goes afterkeys[9]whereas it should be ordered betweenkeys[1]andkeys[2].