Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Abstract.php #45

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update Abstract.php #45

wants to merge 1 commit into from

Conversation

mrodespin
Copy link

Fix issue in php 8.1

  • Return type of Zend_Mail_Storage_Abstract::count() should either be compatible with Countable::count(): int, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in magento/vendor/magento/zendframework1/library/Zend/Mail/Storage/Abstract.php:218

Fix issue in php 8.1

- Return type of Zend_Mail_Storage_Abstract::count() should either be compatible with Countable::count(): int, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in magento/vendor/magento/zendframework1/library/Zend/Mail/Storage/Abstract.php:218
@xmav
Copy link

xmav commented Jun 20, 2022

Hi @mrodespin !
Could you please update your PR and add #[\ReturnTypeWillChange] for all affected methods in this class ?

Would be great if you can share your steps to reproduce the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants