From address empty when the plugin is enabled.

[mariamghalleb]

Magento version #: 2.2.4

Edition (EE, CE, OS, etc): CE

Expected behavior: From Address Email shouldn't be empty.

Actual behavior: From Address Email is empty.

Steps to reproduce:

1. Enable your smtp module
2. Sales->Orders->Select any order->Write down a comment->Notify customer By Email->Submit Email
   3.The email is sent with no "From address" (see attachement)
   

Preconditions

Php 7, Magento CE 2.2.4

PLEASE NOTE:

This occurs only when your SMTP module is enabled.

[srenon]

@mariamghalleb

I'm not able to reproduce your issue on a fresh install of Magento 2.2.4

[mariamghalleb]

can you please screenshot your SMTP configuration?

[palo]

Same here.

  host gmail-smtp-in.l.google.com [***.***.**.**]
    SMTP error from remote mail server after pipelined end of data:
    550-5.7.1 [**.**.***.**      11] Our system has detected that this message is
    550-5.7.1 not RFC 5322 compliant:
    550-5.7.1 'From' header is missing.

Running Magento CE 2.2.4 | PHP 7.0.30 | SMTP pro v1.5.2

Was working fine, not sure which magento update broke it.
Have tried multiple settings.
Can sent correct test email.
Magento order emails are missing 'From' header.
Password recovery is ok.
Nothing relevant in logs.

[palo]

@mariamghalleb quick workaround if your not using multistore:

in 'vendor/magepal/magento2-gmailsmtpapp/Plugin/Mail/TransportPlugin.php' at line 70 add
$message->setFrom('yourshop@example.com');

Example:

        if ($returnPathEmail !== null && $dataHelper->getConfigSetFrom()) {
            $message->clearFrom();
            $message->setFrom($returnPathEmail);
        }
        
        $message->setFrom('yourshop@example.com');

recompile, clear cache, ...

[srenon]

@palo ... you should update to the latest version

[srenon]

@mariamghalleb @palo ... take a look at #113

[palo]

@srenon thanks for helping