Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block magepack during 'generate' command #151

Merged
merged 2 commits into from
Oct 24, 2022

Conversation

fredden
Copy link
Contributor

@fredden fredden commented Jul 28, 2022

Fixes #37
Fixes #65

When magepack bundle has been run, future runs of magepack generate will hang without any useful message / explanation. This pull request prevents magepack from loading when running magepack generate and this avoids the hang.

@krzksz
Copy link
Collaborator

krzksz commented Oct 24, 2022

That's super cleaver, thanks!

@krzksz krzksz merged commit 8dd9400 into magesuite:master Oct 24, 2022
@fredden fredden deleted the disable-magepack-during-generate branch October 24, 2022 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

magepack generate hanging Magepack never ends process with no error
2 participants