enable system diagnostics package to show threading info #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- cleanup existing debugging stuff - gather linux-specific thread ID so we can correlate threads with their system process info in /proc, top, etc - create general purpose framework for registering more diagnostics functions - add very detailed snapshot printout of per-thread stack traces, run status, thread name, etc (these are heavy weapons for diagnosing hung threads / deadlocks) - add basic memory reporting, more coming later
binary1230
changed the title
| """ | ||
| try: | ||
| if not platform.system().startswith('Linux'): | ||
| raise ValueError |
There was a problem hiding this comment.
Not that I expect this to ever actually come up, but in case it ever did, having an actual message with the error would be great, e.g.
raise ValueError('Can only get thread id on Linux systems')
|
+1 great stuff! |
|
added extra message when not running on linux systems |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(these are heavy weapons for diagnosing hung threads / deadlocks)
this is intended to be heavy weaponry for diagnosing future deadlock issues like the one we hit today in magfest/ubersystem#2017