fix for special shift bits generated by putty4far2l #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The fix is simpler than that. Instead of having to know in advance which non-standard flags we may get, we can mask Still, thank you for looking into this! |
magiblot
added a commit
that referenced
this pull request
Jan 6, 2023
putty4far2l (and possibly other applications) use more bits than the ones defined in the Win32 API. See microsoft/terminal#337. This conflicts with our flags. In MS-DOS this is not a problem because THardwareInfo::shiftState() returns a char and all the bits are already in use. Therefore, we can safely reassign kbPaste to the value 0x100. Closes #92. Fixes magiblot/turbo#47.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
putty4far2l supports special bits for distinguishing left and right shift as proposed here: microsoft/terminal#337
but tvision does not supports those bits for now, so shift+some_key combinations become broken.
this PR fixes that.
see #47