Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect broken TCP connection to peer #166

Closed
felinira opened this issue Jul 24, 2022 · 1 comment
Closed

Detect broken TCP connection to peer #166

felinira opened this issue Jul 24, 2022 · 1 comment

Comments

@felinira
Copy link
Collaborator

felinira commented Jul 24, 2022 •
edited
Loading

This is related to #165 but a bit of a different take on the issue.

Reproduction steps:

  • sending file from wormhole-rs
  • receiving from wormhole-python
  • aborting the wormhole-python transfer
  • wormhole-rs will stall

Wormhole-rs should probably detect (maybe after some timeout?) that the other peer is not reachable anymore and throw an error. At least in my experience this doesn't seem to be the case.
@piegamesde

This comment was marked as outdated.

Sign in to view
piegamesde added a commit that referenced this issue Sep 5, 2022
@piegamesde
Transfer: fix hanging on cancellation
2d75e05 
Closes #165
Closes #166
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@felinira @piegamesde