Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move argument parsing to Click, or twisted.python.usage.Options #19

Closed
warner opened this issue Jun 2, 2016 · 3 comments
Closed

move argument parsing to Click, or twisted.python.usage.Options #19

warner opened this issue Jun 2, 2016 · 3 comments

Comments

@warner
Copy link
Collaborator

warner commented Jun 2, 2016

We're currently using argparse for CLI argument processing, but I'd like to move to Twisted's native argv-parsing code (twisted.python.usage.Options). The two goals are:

  • remove a dependency (we're already depending on Twisted anyways)
  • add aliases, so wormhole rx does exactly the same thing as wormhole receive (I keep forgetting how to spell "receive" when doing a demo, how embarrassing!).
@warner
Copy link
Collaborator Author

warner commented Jun 3, 2016

When I asked, Glyph seemed uncertain whether he'd recommend t.p.usage.Options or click. So it might be a good idea to investigate Click and see how it'd look if we went that way instead.

@warner warner changed the title move argument parsing to twisted.python.usage.Options move argument parsing to Click, or twisted.python.usage.Options Jun 3, 2016
@warner
Copy link
Collaborator Author

warner commented Jun 21, 2016

@meejah is working on this in #47

@warner
Copy link
Collaborator Author

warner commented Jun 27, 2016

#47 got landed, so this is done. There are some lingering bugs (--no-listen) seems to be stuck on, for example), but overall it's looking good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant