Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use gitattributes to handle EOL in Windows tests #42

Closed
wants to merge 4 commits into from

Conversation

magicDGS
Copy link
Owner

Fixes #39

@codecov-io
Copy link

codecov-io commented Mar 25, 2018

Codecov Report

Merging #42 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #42   +/-   ##
=========================================
  Coverage     78.74%   78.74%           
  Complexity       96       96           
=========================================
  Files             8        8           
  Lines           287      287           
  Branches         42       42           
=========================================
  Hits            226      226           
  Misses           50       50           
  Partials         11       11

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7149c06...17f3b9d. Read the comment docs.

@magicDGS
Copy link
Owner Author

Won't fix like this, because it is wrong. I think that we should just make guidelines for how to clone the repository in windows and a warning about end of lines, or make the tests not aware of eol.

@magicDGS magicDGS closed this Mar 26, 2018
@magicDGS magicDGS deleted the dgs_windows_eol branch March 26, 2018 08:33
@magicDGS magicDGS added this to In Progress in Backlog via automation Jun 13, 2018
@magicDGS magicDGS moved this from In Progress to Abandoned in Backlog Jun 13, 2018
@magicDGS magicDGS restored the dgs_windows_eol branch June 28, 2018 12:51
@magicDGS magicDGS deleted the dgs_windows_eol branch June 28, 2018 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Backlog
  
Abandoned
Development

Successfully merging this pull request may close these issues.

None yet

2 participants