Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate 'no-preference' as it is no longer supported #4

Merged
merged 1 commit into from
Aug 6, 2021

Conversation

rishabh-ink
Copy link
Collaborator

Background

As mentioned in Detecting the desire for light or dark color schemes: the prefers-color-scheme feature spec,

This feature, like the other prefers-* features, previously had a no-preference value to indicate an author not expressing an active preference. However, user agents converged on expressing the "default" behavior as a light preference, and never matching no-preference.
If a future user agent wishes to expose a difference between "no preference" and "really wants a light display", please contact the CSSWG to discuss this.

Since the "no-preference" value is being replaced by "light" as default, this PR removes it from the codebase and fixes #1.

@rishabh-ink rishabh-ink self-assigned this Aug 6, 2021
@rishabh-ink rishabh-ink merged commit caaae5a into master Aug 6, 2021
@rishabh-ink rishabh-ink deleted the rishabh-1-deprecate branch August 6, 2021 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate "no-preference" in favor of defaulting to "light"
1 participant