completion block is not called when MR_saveInBackgroundErrorHandler:completion: is called on a child of the default context

[blackgold9]

It's currently only going to be called if it's saving the root context. calling it on the default queue causes it to save the root queue (and hence trigger the callback). If you use a child of the default context, it does not get called.
As a result saveInBackgroundWithBlock:completion:errorHandler: (in actions) never fires it's callback because it uses a child context, which is neither the default nor root context.

(hope that was understandable)

[peterpaulis]

fixed with

- (void) MR_saveInBackgroundErrorHandler:(void (^)(NSError *))errorCallback completion:(void (^)(void))completion;
{
    [self performBlockAndWait:^{
        [self MR_saveWithErrorCallback:errorCallback];

        if (self == [[self class] MR_defaultContext])
        {
            [[[self class] MR_rootSavingContext] MR_saveInBackgroundErrorHandler:errorCallback completion:completion];
        } 
        else if (completion)
        {
            dispatch_async(dispatch_get_main_queue(), completion);
        }
    }];
}

[andrewgarn]

I had the same issue with saveInBackgroundWithBlock. Thanks @xelvenone

[mammo]

Thank you, @xelvenone! This caused me much confusion!

[blackgold9]

Fixed by a more tested commit