Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2.2 fix merge only paralell contexts in default #647

Closed
wants to merge 5 commits into from
Closed

2.2 fix merge only paralell contexts in default #647

wants to merge 5 commits into from

Conversation

joergsimon
Copy link

a possible fix for issue: #613
others have issues with context merging their own saves too f.e. RestKit:
RestKit/RestKit#1351

these delete problems do not always seem to occur, so a unit test is hard, I only have one in my own project currently
to some degree I think this is a bug from apple, but that is a possible work around

@joergsimon
disable merges from root context to default
4fae527 
context if changes originated from default
context.

detail: if a save op on the root context originated from a child save op where the save op is the default context, disable the notification for that save.
@joergsimon
avoid some code duplication
4e67f6b
@joergsimon
use 2.2 podspec
a4fff88
@joergsimon
update podspec to take my fork for now
d7e1bea
@joergsimon
disable logging per default in podspec
c6e51a3
@tonyarnold tonyarnold mentioned this pull request Apr 9, 2014
Open
@tonyarnold
Copy link
Contributor

@joergsimon I've left the comment against #613 asking you to take a look at what's in develop for now. I can't merge this PR due to the inclusion of unwanted changes to the podspec, and subsequent changes to the saving category in MagicalRecord, so I'm going to close it.

I'll leave #613 open, but I'm going to go ahead with a release of 2.3.0 and we can look at addressing the issue you've found in a later release. Thanks for taking the time to put this PR together.

@tonyarnold tonyarnold closed this May 28, 2014
@joergsimon
Copy link
Author

Hi @tonyarnold,
Yea, I am working, and also studying at a university (that works in austria at least), and currently have my last exams for my degree, so sorry for being that silent. I am still on that struggle, so I can not guarantee when I have time to write even that small test. So thanks for moving on. In hope I can finish that part, I will notify you then...
Cheers, Joerg

@tonyarnold
Copy link
Contributor

Not to worry — I do understand. Let me know when you have some time, and best of luck with the exams!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@tonyarnold tonyarnold

Labels
Feature Request Needs Confirmation
Projects
None yet
Milestone
2.3.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@joergsimon @tonyarnold