Fixed relationship data import key lookup #723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed an issue where if you have more than one mappedKeyName it would not search through all of the mappedKeyNames to find the correct key for the lookup for a relationship object thus causing a duplicate item to be created in the database. The current implementation takes the first key and assumes it is the correct key. The expected workflow is to check the first key mappedKeyName then if there is no value for that key to move onto the next key mappedKeyName.1 until either a value is found or all mappedKeyNames have gone through.
|
Thanks! I'll merge this into 3.0 as well. |
tonyarnold
added a commit
that referenced
this pull request
Apr 3, 2014
Fix relationship data import key lookup not seeing more than one `mappedKeyName`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed an issue where if you have more than one mappedKeyName it would not search through all of the mappedKeyNames to find the correct key for the lookup for a relationship object thus causing a duplicate item to be created in the database. The current implementation takes the first key and assumes it is the correct key. The expected workflow is to check the first key mappedKeyName then if there is no value for that key to move onto the next key mappedKeyName.1 until either a value is found or all mappedKeyNames have gone through.