Separate parsing and evaluation in arithmetic expansion #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
The previous implementation used absolute indices, which required a whole slice of the containing vector to resolve child nodes. By using relative indices, we will only need a local slice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refactors the arithmetic expansion implementation.
Previously, We performed syntax parsing and evaluation in a single pass. This PR splits them into separate processes.
The motivation for this refactoring comes from the difficulty in implementing and testing the evaluation
Mode. To implement conditional evaluation required by the||,&&, and? :operator, we need to conditionally skip evaluation of part of the expression and prevent any side effects. We used theModeflag to indicate the condition to trigger skipping, but we still need to parse the whole expression syntax regardless of the flag. That was making the implementation complicated and hard to understand.By separating the parser from evaluation, skipping evaluation can be coded much more intuitively just by not calling the evaluation function.