Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Creating subshells #60

Merged
merged 8 commits into from
Jul 5, 2021
Merged

Creating subshells #60

merged 8 commits into from
Jul 5, 2021

Conversation

magicant
Copy link
Owner

@magicant magicant commented Jul 3, 2021 •
edited
Loading

  • Define System::fork function
  • Implement System::fork for RealSystem
  • Implement System::fork for VirtualSystem
  • Define System::wait function
  • Implement System::wait for RealSystem
    • TODO: In this pull request, wait will be blocking, but eventually it should be non-blocking.
  • Implement System::wait for VirtualSystem
  • Add JobSet to Env
  • Implement Env::run_in_subshell
    • TODO: Update control flow state in the subshell

@magicant
Always require nix crate
34b588a 
The signature of the System trait is going on to depend on types defined
in the nix crate. It is no longer helpful to support disabling the
real-system feature and the nix crate.
@magicant magicant self-assigned this Jul 3, 2021
@magicant magicant mentioned this pull request Jul 3, 2021
Closed
4 tasks
@magicant
Copy link
Owner Author

magicant commented Jul 3, 2021

Implement Env::run_in_subshell

The run_in_subshell function starts a subshell and waits for it to finish. This function cannot be used for an asynchronous subshell or job-controlled process.

@magicant
Define System::wait
fd193cb
@magicant
Change ExitStatus to c_int
76251bc 
POSIX defines the exit status as a signed integer. See exit(3p).
@magicant
Implement Env::run_in_subshell
893465c
@magicant magicant marked this pull request as ready for review July 5, 2021 01:59
@magicant
Copy link
Owner Author

magicant commented Jul 5, 2021

JobEnv was not necessary for the goal of this pull request, but it won't do any harm anyway...

@magicant magicant merged commit 1d205b2 into master Jul 5, 2021
@magicant magicant deleted the subshell branch July 5, 2021 13:51
@magicant magicant mentioned this pull request Jul 8, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@magicant magicant

Labels
None yet
Projects
yash-rs
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@magicant