Minimum redirection semantics #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Redirections performed in a subshell should be shared in an Rc so that the subshell can access the redirections asynchronously without creating a clone.
The following snippet does not compile because of conflicting borrows.
To work out, RedirEnv should be created by the caller of the perform
function, rather than being returned from the function.
let mut env = match redir::perform(env, &redirs).await {
Ok(env) => env,
Err(_) => return drop(e.handle(env).await),
};
in favor of RedirEnv::perform_redir
for better documentation rendering
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request implements the
<redirection for external utility in simple command.System::openSimpleCommand::redirsinRc