feat: Allow passing multiple entities in the ApplySystem function #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crypto-vincent
changed the title
…github.com:magicblock-labs/bolt into vbrunet/2024_06_12-update-transaction-apply-system
crypto-vincent
commented
Jun 14, 2024
| ); | ||
| return { | ||
| transaction: new Transaction().add(createEntityIx), | ||
| entityPda, | ||
| entityId, |
There was a problem hiding this comment.
removing this entityId because this might not be correct if the user passed a seed as parameter. This should not be part of the public API imo.
crypto-vincent
commented
Jun 14, 2024
| authority: PublicKey; | ||
| seeds?: string[]; | ||
| systemId: PublicKey; | ||
| entities: ApplySystemEntity[]; |
There was a problem hiding this comment.
this is the main change to the API
crypto-vincent
deleted the
vbrunet/2024_06_12-update-transaction-apply-system
branch
crypto-vincent
added a commit
to magicblock-labs/docs
that referenced
this pull request
Jun 17, 2024
# Summary `ApplySystem` typescript API has changed, we update the docs to match that. # Details `ApplySystem` can now take an array of entities instead of a single entity as parameter. Also removed the use of `entityId`. Also mention we can read the state from the `componentPda`. # Notes Matching PR for `bolt-sdk` change: magicblock-labs/bolt#51
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
It was previously impossible to pass components from multiple entities in the same system from the typescript SDK.
Solution
Changing the
ApplySystemfunction to accommodate for multiple entities.Other changes (e.g. bug fixes, small refactors)
Refactored the integration tests to use the highest level API to increase testing surface.
Also improved some of the error tests:
Removed the unused
bolt.jsNotes
Matching PR for docs update: magicblock-labs/docs#6