Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 7 compatability #177

Closed
thenorthcore opened this issue Jan 11, 2016 · 10 comments · Fixed by #206
Closed

PHP 7 compatability #177

thenorthcore opened this issue Jan 11, 2016 · 10 comments · Fixed by #206
Labels
Bug Ah shit, we broke something

Comments

@thenorthcore
Copy link

Hej hej,
updated to PHP 7 and running into issues now. Start page returns:
'''
A PHP Error was encountered
Severity: Notice
Message: Only variables should be assigned by reference
Filename: core/Controller.php
Line Number: 51
'''
Looks like CodeIgniter is using some depricated statements. Any suggestions besides downgrading PHP?

Cheers,
Jens

@magicbug
Copy link
Owner

Current version of codeigniter that cloudlog uses isn't php7 ready, so
sadly the only option is to downgrade for now.

I've not checked how badly the latest codeigniter update breaks the system
yet.

Peter
On 11 Jan 2016 09:08, "Jens Abraham" notifications@github.com wrote:

Hej hej,
updated to PHP 7 and running into issues now Start page returns:
'''
A PHP Error was encountered
Severity: Notice
Message: Only variables should be assigned by reference
Filename: core/Controllerphp
Line Number: 51
'''
Looks like CodeIgniter is using some depricated statements Any suggestions
besides downgrading PHP?

Cheers,
Jens


Reply to this email directly or view it on GitHub
#177.

@magicbug magicbug added the Bug Ah shit, we broke something label Jan 11, 2016
@thenorthcore
Copy link
Author

I'm on my way in merging the latest CodeIgniter updates up to 2.2.6. Have to add a database migration file for the minor changes in CIs databases. Migration up to 3.x series is a more advanced endeavour...

@magicbug
Copy link
Owner

Yeah I have a sneaky feeling 3x might require some large rewrites in places
but 2.x should in theory merge up ok

On 16 January 2016 at 13:41, Jens Abraham notifications@github.com wrote:

I'm on my way in merging the latest CodeIgniter updates up to 2.2.6. Have
to add a database migration file for the minor changes in CIs databases.
Migration up to 3.x series is a more advanced endeavour...


Reply to this email directly or view it on GitHub
#177 (comment).

Peter Goodhall

@thenorthcore
Copy link
Author

I've updated my local instance to CI 2.2.6. It's working so far under PHP 5.X without any noticible change. Unfortunatly CI seems to support PHP 7 only in the 3.X branch.

@magicbug
Copy link
Owner

magicbug commented Feb 9, 2016

Yeah, switching to 3x would require near on rewrite i think, and by then might as well start considering my plans for cloudlog v2 :)

@wvolz
Copy link
Contributor

wvolz commented Dec 1, 2017

I have a working new install of Cloudlog running on CI 3.1.6 and PHP7. I haven't tested the code to upgrade older databases yet, but will try to do that soon. Pull request will come shortly unless you would like me to post a link to my fork.

@magicbug
Copy link
Owner

magicbug commented Dec 1, 2017

Pull would be fantastic @wvolz sadly development halted my end due to health issues and moving.

@wvolz
Copy link
Contributor

wvolz commented Dec 1, 2017

Pull request #206 created.

@magicbug
Copy link
Owner

magicbug commented Dec 5, 2017

Thanks @wvolz soon as I get time to test i'll merge

@magicbug
Copy link
Owner

Thanks @wvolz Cloudlog is now PHP7 ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Ah shit, we broke something
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants