Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAP] Simplify call function for map json data #2810

Merged
merged 18 commits into from
Dec 28, 2023
Merged

[MAP] Simplify call function for map json data #2810

merged 18 commits into from
Dec 28, 2023

Conversation

abarrau
Copy link
Contributor

@abarrau abarrau commented Dec 12, 2023

Hello,
The same bloc code is used on different place of cloudlog code. This PR propose an unique function.
After this, it's more simple to add more evolution.

@abarrau
Copy link
Contributor Author

abarrau commented Dec 12, 2023

Question for Team :
the URL https://<url>/index.php/map, not exist on menu ; this map is always use ? (return qso for active station only)

@abarrau abarrau marked this pull request as ready for review December 13, 2023 21:55
@HB9HIL
Copy link
Contributor

HB9HIL commented Dec 20, 2023

This PR breaks at least the QSL confirmation's in the maps. Nothing else was changed, just changed branches...

ON DEV:

dev

....

ON PR:

pr

@abarrau
Copy link
Contributor Author

abarrau commented Dec 21, 2023

This PR breaks at least the QSL confirmation's in the maps. Nothing else was changed, just changed branches...

Sorry for this, fixed

@magicbug
Copy link
Owner

Looks more fixed, can someone confirm before I plonk it into dev branch

@AndreasK79
Copy link
Contributor

@magicbug everything seems to be working as far as I can tell. The only difference is the /map url that @abarrau asked about. I don't know what the purpose of that map is. In dev it displays a bunch of QSOs (all?), while in this PR, only a few.

@AndreasK79
Copy link
Contributor

@abarrau good job finding this and refactor them to a common function.

@abarrau
Copy link
Contributor Author

abarrau commented Dec 22, 2023

Just an information, perhaps some function must be removed if it is no longer used.

@magicbug
Copy link
Owner

I think its safe to remove, it was the original map view in Cloudlog back in the day.

@abarrau
Copy link
Contributor Author

abarrau commented Dec 27, 2023

I think its safe to remove, it was the original map view in Cloudlog back in the day.

Hello @magicbug Peter, so i can remove this part of code (old map view), because it will be never used ?
If ok, i will do that.

@AndreasK79
Copy link
Contributor

@abarrau yes. Remove it.

@abarrau
Copy link
Contributor Author

abarrau commented Dec 27, 2023

@abarrau yes. Remove it.

@AndreasK79, ok done !
If any question, tell me.

@AndreasK79 AndreasK79 merged commit 77a1c07 into magicbug:dev Dec 28, 2023
@abarrau abarrau deleted the map-simplify-centralize-json-call branch December 28, 2023 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants