-
-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MAP] Simplify call function for map json data #2810
[MAP] Simplify call function for map json data #2810
Conversation
Question for Team : |
Sorry for this, fixed |
Looks more fixed, can someone confirm before I plonk it into dev branch |
@abarrau good job finding this and refactor them to a common function. |
Just an information, perhaps some function must be removed if it is no longer used. |
I think its safe to remove, it was the original map view in Cloudlog back in the day. |
Hello @magicbug Peter, so i can remove this part of code (old map view), because it will be never used ? |
@abarrau yes. Remove it. |
@AndreasK79, ok done ! |
Hello,
The same bloc code is used on different place of cloudlog code. This PR propose an unique function.
After this, it's more simple to add more evolution.