Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QSO] fix menu action display #2869

Merged
merged 9 commits into from
Dec 30, 2023
Merged

[QSO] fix menu action display #2869

merged 9 commits into from
Dec 30, 2023

Conversation

abarrau
Copy link
Contributor

@abarrau abarrau commented Dec 22, 2023

after speaking with @HB9HIL , i propose this PR about dropdown menu view.
hope it will be ok for you

for test :

  • logbook page = ok
  • search = ok (but left position = improvement to think about)
  • advanced search = ok (but left position = improvement to think about)
  • analytics / gridsqure map = ok
  • analytics / Activated Gridsquare = ok
  • analytics / Distances Worked = ok
  • awards / cq / table = ok - map = /!\ (result don't display on clic ?)
  • awards / DOK / table = ok
  • awards / DXCC / map = ok (but display qso detail is very slow)
  • awards / FFMA = not tested
  • awards / IOTA / map = /!\ (result don't display on clic ?)
  • awards / gridmaster (tested only on JA Gridmaster) = ok .. todo = tested more
  • awards / WAJA / map = not tested
  • awards / WAS / map = not tested

i can not tested all page, sorry (didn't have data)

@abarrau abarrau marked this pull request as ready for review December 27, 2023 19:27
@AndreasK79
Copy link
Contributor

@abarrau great work. This is a nice fix.

Tested working most places:

  • FFMA does not work.
  • CQ Map works
  • IOTA Map works
  • WAS / WAS Map works
  • WAJA / WAJA Map works
  • Also tested the rest, except for gridmaster

For IOTA and CQ map, you need to click the label to get the popup.
Not tested the gridmaster maps. @phl0 could you do a test here?

@abarrau
Copy link
Contributor Author

abarrau commented Dec 28, 2023

@AndreasK79, thanks for feedback
how can i test the "FFMA" ? (some data example for testing that ?)

@AndreasK79
Copy link
Contributor

@AndreasK79, thanks for feedback how can i test the "FFMA" ? (some data example for testing that ?)

@abarrau yes. Log a QSO with USA on 6M with grid FN44.

@abarrau
Copy link
Contributor Author

abarrau commented Dec 29, 2023

ok, i have find the fix for ffma (it was on ffma.js) ... but not access to my dev for make fixe.
i will do this after the 3st january ... tnx

@AndreasK79
Copy link
Contributor

@abarrau no problem. I pushed the FFMA fix to this PR.

@AndreasK79
Copy link
Contributor

The Gridmaster maps are tested as well. It's merge time. Thanks @abarrau for the good job! Keep it up.

@AndreasK79 AndreasK79 merged commit d3d5d7c into magicbug:dev Dec 30, 2023
@HB9HIL
Copy link
Contributor

HB9HIL commented Dec 31, 2023

@abarrau Congrats :)

@abarrau
Copy link
Contributor Author

abarrau commented Dec 31, 2023

Thanks all

@abarrau abarrau deleted the ans-fix-menudropdown branch March 10, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants