New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Neutral Spanish translation plus Datatable translation PoC #2888

Merged

magicbug merged 7 commits into magicbug:dev from Tamh:dev

Jan 2, 2024

Contributor

Tamh commented Dec 30, 2023

This MR attempts to:

Update the Spanish translation to use a neutral translation, some string corrections, along with translating new strings that were untranslated.
Support the translation of the included DataTables strings using their provided translation JSON files.

Tamh added 3 commits

December 29, 2023 22:11


          Initial commit

41f1d61


          Add datatable translation capability

f262c07


          Correct language route

1e718ef

daniestevez reviewed

View reviewed changes

Contributor

daniestevez left a comment

Some context: @magicbug asked on Twitter if there were Spanish speaking hams that would review this PR, and I've gone ahead and done it. I'm a native Spanish speaker (born and living in Spain) and a ham operator. I've found a few typos here and there, but most of my comments are about idiomatic use of Spanish (and also ham radio jargon in Spanish, as my fellow hams from Spain and I use it). Some of the wording in this PR seems Latin-American to me. I've indicated what would feel more natural to me in Spain Spanish. I'm not implying that the PR should use Spain Spanish over Latin-American Spanish (this is probably for @magicbug to decide whether it makes sense to have separate Spanish variants). All I can say is that I can't judge whether the wording in this PR is idiomatic Latin-American Spanish (so I've always judged on the grounds of Spain Spanish) and that most Spanish speakers in Spain would find some of this wording weird.

I haven't reviewed the files that start by "System messages translation for CodeIgniter(tm)", since I imagine that this is a 3rd party translation that has been fetched from somewhere else.

application/language/spanish/account_lang.php

		$lang['account_logbook_fields'] = 'Campos a mostrar en el Logbook';
		$lang['account_logbook_fields'] = 'Campos a mostrar en el Libro de Guardia';

Contributor

daniestevez Dec 30, 2023

I don't know if "Libro de Guardia" would be the best translation of "Logbook" when used for ham radio. It would be good to know what other Spanish speaking hams use. I often call it "log", but that's English.

Contributor Author

Tamh Dec 30, 2023

¡Hola @daniestevez y gracias!

Thanks for taking your time to review this mammoth PR.

About this particular one, I did a small survey of different Spanish-speaking amateur radio associations around the world, namely Argentina (LU4BB), Ecuador (HD1A) and Spain (EA4URE), along with some of the regulation around amateur radio in some countries (Colombia, Costa Rica and Paraguay mainly), and it seemed that "libro de guardia" is a well known word for this purpose.

Contributor

daniestevez Dec 31, 2023

Let's go ahead with "Libro de Guardia" then.

application/language/spanish/account_lang.php Outdated

-              $lang['account_first_name'] = 'First Name';
-              $lang['account_last_name'] = 'Last Name';
+              $lang['account_personal_information'] = 'Información Personal';
+              $lang['account_first_name'] = 'Nomnbres';

Contributor

daniestevez Dec 30, 2023

Suggested change

      
            $lang['account_first_name'] = 'Nomnbres';
          
            $lang['account_first_name'] = 'Nombre';

application/language/spanish/account_lang.php Outdated

-              $lang['account_hamradio_information'] = "Ham Radio";
-              $lang['account_callsign'] = 'Callsign';
+              $lang['account_hamradio_information'] = "Info de Radioaficionado";

Contributor

daniestevez Dec 30, 2023

Maybe "Información" instead of "Info"? I don't know if that would be too long.

Contributor Author

Tamh Dec 31, 2023

This is used as a card header in the User Edit page, thus it is reasonable to use the longer version.

This section groups out the Callsign and Gridsquare options.

application/language/spanish/account_lang.php Outdated

-              $lang['account_upload_status_of_sat_qsos_to'] = 'Upload status of SAT QSOs to';
+              $lang['account_cloudlog_preferences'] = 'Preferencias de Cloudlog';
+              $lang['account_timezone'] = 'Zona Horaria';
+              $lang['account_date_format'] = 'Formato de Fechas';

Contributor

daniestevez Dec 30, 2023

I would say "Formato de Fecha" here.

application/language/spanish/account_lang.php Outdated

Comment on lines 40 to 41

		$lang['account_log_end_time'] = 'Guardar Horas de Finalización para QSOs Separadamente';
		$lang['account_log_end_time_hint'] = 'Escoja \'Si\' aquí si desea guardar las horas de inicio y fin del QSO separadamente. Si se configura como \'No\' la hora de fin y de inicio serán la misma.';

Contributor

daniestevez Dec 30, 2023

Likewise, I would say "Hora" rather than "Horas" in this context. Maybe "por separado" is more idiomatic than "separadamente".

application/language/spanish/station_lang.php

+              $lang['station_location_hrdlog_code'] = "Código API de HRDLog.net";
+              $lang['station_location_hrdlog_realtime_upload'] = "Subida en Tiempo Real del Libro de Guardia a HRDLog.net";
+              $lang['station_location_hrdlog_code_hint'] = "Cree su código API en <a href='http://www.hrdlog.net/EditUser.aspx' target='_blank'>la página de perfil de usuario de HRDLog.net";
+              $lang['station_location_qo100_hint'] = "Cree su llave API en <a href='https://qo100dx.club' target='_blank'>su página perfil de QO-100 Dx Club";

Contributor

daniestevez Dec 30, 2023

"Clave" rather than "llave".

application/language/spanish/statistics_lang.php Outdated

+              $lang['statistics_distances_part2_contacts_were_plotted_furthest'] = "en gridsquare";
+              $lang['statistics_distances_part3_contacts_were_plotted_furthest'] = "la distancia fue";
+              $lang['statistics_distances_number_of_qsos'] = "Número de QSOs";
+              $lang['statistics_distances_callsigns_worked'] = "Indicativo(s) logrados (máximo se muestran 5)";

Contributor

daniestevez Dec 30, 2023

I would say just "máximo 5" or "se muestran máximo 5".

Also "trabajados" instead of "logrados".

assets/json/datatables_languages/es-ES.json

Comment on lines +42 to +43

		"removeAllStates": "Remover Estados",
		"removeState": "Remover",

Contributor

daniestevez Dec 30, 2023

"Eliminar" instead of "remover".

Contributor Author

Tamh Dec 31, 2023

This file is manually imported from the DataTables library.

I also feel this line is wrongly translated, but since it could theoretically be overwritten by a new release, I don't know if it is worth translating it.

Contributor

HB9HIL Dec 31, 2023

@Tamh we don't update such libraries periodically, and such a library wouldn't change much. From my perspective, the benefit compared to the effort is in a good balance.

Contributor

daniestevez Dec 31, 2023

But I agree that the translation should be best updated upstream. Maybe it's possible to leave it as such for now but send a PR to upstream.

assets/json/datatables_languages/es-ES.json

+                              "without": "Sin"
+                          }
+                      },
+                      "data": "Data",

Contributor

daniestevez Dec 30, 2023

"Datos" maybe? I'm missing context on this one.

assets/json/datatables_languages/es-ES.json

+                      "renameButton": "Cambiar Nombre",
+                      "duplicateError": "Ya existe un Estado con este nombre.",
+                      "emptyStates": "No hay Estados guardados",
+                      "removeTitle": "Remover Estado",

Contributor

daniestevez Dec 30, 2023

Eliminar rather than remover.

Contributor

HB9HIL commented Dec 31, 2023

I'm not pretty happy with your datatables language solution. So I tried to make it available overall cloudlog.

But maybe we have to think about how we could avoid the single language lines in general_lang.php... I don't know atm

Tamh added 2 commits

December 30, 2023 21:18


          Fix some translated strings

ad1c3af


          Merge branch 'magicbug:dev' into dev

b86cb45

daniestevez reviewed

View reviewed changes

application/language/spanish/adif_lang.php

@@ @@ -113,7 +113,7 @@ @@
               $lang['adif_import_dupes_skipped'] = " Se descartaron registros duplicados.";
               $lang['adif_import_errors'] = "Errores ADIF";
-              $lang['adif_import_errors_hint'] = "Tiene errores en su archivo ADIF, los QSOs han sido adicionados, pero estos campos no han sido importados.";
+              $lang['adif_import_errors_hint'] = "Tiene errores en su archivo ADIF. Los QSOs han sido adicionados, pero estos campos no han sido importados.";

Contributor

daniestevez Dec 31, 2023

"Añadidos" instead of "adicionados".

daniestevez reviewed

View reviewed changes

application/language/spanish/admin_lang.php Outdated Show resolved Hide resolved

magicbug and others added 2 commits

January 1, 2024 16:38


          Update application/language/spanish/admin_lang.php

a3373e2

Co-authored-by: Daniel Estévez <daniel@destevez.net>


          Merge branch 'dev' into dev

031954f

magicbug merged commit bd55897 into magicbug:dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment