Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WWFF Improvements #2906

Merged

Conversation

hugosilvaparagramanet
Copy link
Contributor

Two minor adjustments on WWFF handling:

  • on Advanced Log, show WWFF references in REF columns accounting for the possibility of both specific de/dx WWFF and sig fields are set. If both are set, priority is for the station WWFF_REF
  • on ADIF export, handle both specific de/dx WWFF and sig fields. If both are set, priority is for the station WWFF_REF

@magicbug
Copy link
Owner

magicbug commented Jan 3, 2024

Looks good thanks @hugosilvaparagramanet

@magicbug magicbug merged commit 46eca8c into magicbug:dev Jan 3, 2024
1 check passed
@phl0
Copy link
Contributor

phl0 commented Jan 6, 2024

I have a concern: With this "new" export we have WWFF refs twice in the export:

Screenshot from 2024-01-06 06-53-34

ADIF standard has a separate WWFF_REF field for this introduced in v3.13. See http://adif.org.uk/313/ADIF_313_annotated.htm. Where is the point to also set this in SIG/SIG_INFO (again)?

@hugosilvaparagramanet
Copy link
Contributor Author

The purpose was to support legacy apps, but you're right, there's no need for that. Apparently WWFF.co already looks for the new fields, so this is really unnecessary. What Cloudlog should do IMO is the opposite: if there's a SIG WWFF, export it as WWFF_REF.

I will confirm WWFF.co accepts the new fields and then do a new MR wich:

  • removes the "also export as SIG"
  • removes the "also export as MY_SIG"
  • if SIG is WWFF, export as WWFF_REF
  • if MY_SIG is WWFF, export as MY_WWFF_REF

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants