Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workable hamsat passes #3003

Merged
merged 2 commits into from
Mar 11, 2024
Merged

Workable hamsat passes #3003

merged 2 commits into from
Mar 11, 2024

Conversation

phl0
Copy link
Contributor

@phl0 phl0 commented Mar 9, 2024

This adds a user account option to configure the hams.at private feed key and allow the hams.at page to show only workable passes.

@magicbug magicbug merged commit 135db2c into magicbug:dev Mar 11, 2024
1 check passed
@magicbug
Copy link
Owner

Merged a little early some errors

A PHP Error was encountered
Severity: Notice

Message: Undefined property: stdClass::$hamsat_key

Filename: controllers/User.php

Line Number: 501

A PHP Error was encountered
Severity: Notice

Message: Undefined property: stdClass::$hamsat_workable_only

Filename: controllers/User.php

Line Number: 507

@phl0
Copy link
Contributor Author

phl0 commented Mar 11, 2024

I shall have a look a fix.

@magicbug
Copy link
Owner

Got the errors fixed with the commit I just added, but its not saving the field data at the moment

@magicbug
Copy link
Owner

OKay so its saving okay, its just not getting the data from the user config table and displaying it on the form

@magicbug
Copy link
Owner

OK think i've fixed it :)

@phl0
Copy link
Contributor Author

phl0 commented Mar 11, 2024

Ok tnx.

@phl0
Copy link
Contributor Author

phl0 commented Mar 11, 2024

Jepp. Its fixed. I missed to copy over the port to user options table. D'oh :)

@phl0 phl0 deleted the workableHamsatPasses branch March 11, 2024 20:00
@stevendodd
Copy link

This is a great feature thank you. Is there any way to also show FM satellites - at the moment I am just seeing linear and data

@magicbug
Copy link
Owner

We dont filter by satellite type? its showing what passes people plan to activate.

@stevendodd
Copy link

Ah; shame they don't give you access to the pass data. I guess it's the whole purpose of the website to support Rovers

@magicbug
Copy link
Owner

I'm honestly confused? https://hams.at allows the user to find and select passes they plan to operate this is any mode/sat what this PR shows are those activations that are within the footprint of your grid you have given to hamsat. You can of course not provide the API key and it will show you everything that's planned around the world.

@stevendodd
Copy link

stevendodd commented Mar 21, 2024 via email

@phl0
Copy link
Contributor Author

phl0 commented Mar 21, 2024

Well this is not the (primary) purpose of hams.at. You can lookup all possible passes there though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants