Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit Grid square to 6 chars in request to df2et.de API #3042

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

DanielBausset
Copy link
Contributor

In the account settings, the Locator can contain up to 16 characters.
In the Sattimers controller, the API call to df2et.de uses this locator.
But the df2et.de API works only with 6-characters locators maximum.
So this patch just crops the locator to 6 characters max before calling the df2et.de API :)

73

@phl0
Copy link
Contributor

phl0 commented Mar 31, 2024

This is a good find. But I rarher fixed the code upstream so that the API call works with more than 6 chars. :-)

@DanielBausset
Copy link
Contributor Author

Hi Florian, indeed that'd be even better if you could improve this :)

73

@phl0
Copy link
Contributor

phl0 commented Apr 1, 2024

Hi Florian, indeed that'd be even better if you could improve this :)

I did already. Was implemented by the time I commented. Can you confirm that it is working (again)?

@DanielBausset
Copy link
Contributor Author

I confirm that it's working, I just tested it with a locator up to 10 characters.

@magicbug
Copy link
Owner

magicbug commented Apr 2, 2024

@phl0 Shall we keep this on the API end rather than a change inside Cloudlog? your shout let me know

Copy link
Contributor

@phl0 phl0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well ok to merge in though fix is in the API already. But guess it would not harm.

@magicbug magicbug merged commit f8eeaab into magicbug:dev Apr 2, 2024
@DanielBausset DanielBausset deleted the sattimers_6_chars_grid branch April 2, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants