Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1720
only if the public search option is enabledHappy to update this PR if you'd rather a different config option or any other feedback, but to me it felt like if search is enabled then pagination might make sense too. My biggest concern would be that people who have this feature enabled currently might not want the paginated results.Enhancements to public search functionality:
application/controllers/Visitor.php
: In theindex
function, added a condition to load and initialize the pagination library only if public search is enabled. The pagination configuration includes settings for the base URL, total rows, per page limit, number of links, and various HTML tags and attributes for styling the pagination links.application/controllers/Visitor.php
: Modified the data fetching logic in theindex
function to return paginated results when public search is enabled, otherwise it continues to return the last 18 records as before.application/views/visitor/index.php
: updated the condition and loop to use the newresults
variable instead oflast_five_qsos
. Also added a condition to display pagination links at the end of the table if public search is enabled.Gif of feature working: