You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If using git for Windows, the EOL is converted and thus tests relying on reading all bytes from a file are not working. There are two possibilities to fix this problem:
Change tests to do not check bytes but lines, removing the system-specific EOL.
Add .gitattributes specific for the docs folder, where the line endings are kept as they are (also important for formatting docs, I guess)
In addition, we should test this on the CI (see #38)
The text was updated successfully, but these errors were encountered:
After adding the AppVeyor-CI, this is failing only locally. Thus, this should be fixed on my local computer and not at the repository level. Nevertheless, it would be nice to have a test for allowing also windows users to download with the configuration of Windows Git which change line endings...
Closing in favor of recommendations for Windows (#43). Changing to do not check line endings sounds wrong to me, because it can introduce bugs in compressed files if tested at some point.
If using git for Windows, the EOL is converted and thus tests relying on reading all bytes from a file are not working. There are two possibilities to fix this problem:
In addition, we should test this on the CI (see #38)
The text was updated successfully, but these errors were encountered: