Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests failing in windows due to line endings #39

Closed
magicDGS opened this issue Mar 25, 2018 · 3 comments
Closed

Tests failing in windows due to line endings #39

magicDGS opened this issue Mar 25, 2018 · 3 comments

Comments

@magicDGS
Copy link
Owner

If using git for Windows, the EOL is converted and thus tests relying on reading all bytes from a file are not working. There are two possibilities to fix this problem:

  • Change tests to do not check bytes but lines, removing the system-specific EOL.
  • Add .gitattributes specific for the docs folder, where the line endings are kept as they are (also important for formatting docs, I guess)

In addition, we should test this on the CI (see #38)

@magicDGS
Copy link
Owner Author

@magicDGS
Copy link
Owner Author

After adding the AppVeyor-CI, this is failing only locally. Thus, this should be fixed on my local computer and not at the repository level. Nevertheless, it would be nice to have a test for allowing also windows users to download with the configuration of Windows Git which change line endings...

@magicDGS
Copy link
Owner Author

Closing in favor of recommendations for Windows (#43). Changing to do not check line endings sounds wrong to me, because it can introduce bugs in compressed files if tested at some point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Backlog
  
Abandoned
Development

No branches or pull requests

1 participant