fix moved EventEmitter in RN-0.48.x #10
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/EventEmitter` => `react-native/Libraries/vendor/emitter/EventEmitter`
This was referenced Sep 11, 2017
Closed
|
Can we get this merged & released? Hate working off a fork... |
|
I agree, I followed similar advice found in Firebase: facebook/react-native#4968 and it works, but I don't want to have to edit my NPM node modules. Thanks for all your hard work! |
|
I suggested a PR #11 which has no breaking changes. Instead of using the React Native event emitter, it uses a third party one with the same API. |
|
why not just use DeviceEventEmitter of 'react-native' ? It acts the same as I know. |
|
@kinka so that there is no breaking change. A lot of tools depend on this module, and they would all need to implement the same specific breaking change (have a specific version for RN < 0.48 and another for RN >= 0.48) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix issue #9