Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify scripts #147

Merged
merged 2 commits into from Oct 26, 2020
Merged

Simplify scripts #147

merged 2 commits into from Oct 26, 2020

Conversation

smithki
Copy link
Contributor

@smithki smithki commented Oct 26, 2020

📦 Pull Request

Attempts to simplify our build scripts somewhat (remove glob.ts and uses wsrun for pre-commit hook).

✅ Fixed Issues

  • N/A

🚨 Test instructions

yarn test

⚠️ Don't forget to add a semver label!

  • patch: Bug Fix?
  • minor: New Feature?
  • major: Breaking Change?
  • skip-release: It's unnecessary to publish this change.

@smithki smithki added skip-release Preserve the current version when merged internal Changes only affect the internal API labels Oct 26, 2020
@smithki smithki merged commit 61997a4 into master Oct 26, 2020
@smithki smithki deleted the simplify-scripts branch October 26, 2020 01:15
@smithki
Copy link
Contributor Author

smithki commented Nov 17, 2020

🚀 PR was released in @magic-sdk/commons@1.0.0, @magic-sdk/provider@4.0.0, @magic-sdk/react-native@4.0.0, @magic-sdk/types@3.0.0, magic-sdk@4.0.0 🚀

@smithki smithki added the released This issue/pull request has been released. label Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
internal Changes only affect the internal API released This issue/pull request has been released. skip-release Preserve the current version when merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@smithki