Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move third party wallet connections to sdk #473

Merged
merged 12 commits into from Mar 24, 2023
Merged

Conversation

hcote
Copy link
Contributor

@hcote hcote commented Mar 10, 2023

📦 Pull Request

[Provide a general summary of the pull request here.]

  • Adds Coinbase Wallet and Wallet Connect dependencies
  • Adds a new optional parameter thirdPartyWalletOptions to the Magic constructor options (required if using Magic Connect with Coinbase Wallet or Wallet Connect enabled)
  • Adds a new magic.wallet.getProvider() method that returns the provider of the active wallet
  • Moves third party wallet connection logic to the sdk

✅ Fixed Issues

  • [List any fixed issues here like: Fixes #XXXX]

🚨 Test instructions

[Describe any additional context required to test the PR/feature/bug fix.]

⚠️ Don't forget to add a semver label!

Please only add one label:

  • patch: Bug Fix?
  • minor: New Feature?
  • major: Breaking Change?
  • skip-release: It's unnecessary to publish this change.

mattupham
mattupham previously approved these changes Mar 21, 2023
mattupham
mattupham previously approved these changes Mar 22, 2023
@hcote hcote added the major Increment the major version when merged label Mar 22, 2023
bcleary06
bcleary06 previously approved these changes Mar 23, 2023
@hcote hcote dismissed stale reviews from bcleary06 and mattupham via a28ce38 March 23, 2023 20:02
mattupham
mattupham previously approved these changes Mar 23, 2023
@hcote hcote merged commit 5e3070a into master Mar 24, 2023
2 checks passed
@hcote hcote deleted the hcote-move-3pw-to-sdk branch March 24, 2023 16:10
@magiclabsFE magiclabsFE added the released This issue/pull request has been released. label Mar 24, 2023
Ariflo added a commit that referenced this pull request Mar 25, 2023
Ariflo added a commit that referenced this pull request Mar 27, 2023
…connect-updates

Revert "move third party wallet connections to sdk (#473)"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
major Increment the major version when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants