Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jayhwang type issues #606

Merged
merged 2 commits into from Aug 11, 2023
Merged

Jayhwang type issues #606

merged 2 commits into from Aug 11, 2023

Conversation

octave08
Copy link
Collaborator

@octave08 octave08 commented Aug 10, 2023

πŸ“¦ Pull Request

[Provide a general summary of the pull request here.]

  • Fix invalid API parameter
  • Refactor types

βœ… Fixed Issues

  • [List any fixed issues here like: Fixes #XXXX]

🚨 Test instructions

[Describe any additional context required to test the PR/feature/bug fix.]

⚠️ Don't forget to add a semver label!

Please only add one label:

  • patch: Bug Fix?
  • minor: New Feature?
  • major: Breaking Change?
  • skip-release: It's unnecessary to publish this change.
πŸ“¦ Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @magic-ext/algorand@14.1.1-canary.606.5826677077.0
npm install @magic-ext/aptos@2.1.1-canary.606.5826677077.0
npm install @magic-ext/auth@2.1.1-canary.606.5826677077.0
npm install @magic-ext/avalanche@14.1.1-canary.606.5826677077.0
npm install @magic-ext/bitcoin@14.1.1-canary.606.5826677077.0
npm install @magic-ext/conflux@12.1.1-canary.606.5826677077.0
npm install @magic-ext/cosmos@14.1.1-canary.606.5826677077.0
npm install @magic-ext/ed25519@10.1.1-canary.606.5826677077.0
npm install @magic-ext/flow@14.1.1-canary.606.5826677077.0
npm install @magic-ext/gdkms@2.1.1-canary.606.5826677077.0
npm install @magic-ext/harmony@14.2.1-canary.606.5826677077.0
npm install @magic-ext/icon@14.1.1-canary.606.5826677077.0
npm install @magic-ext/near@14.1.1-canary.606.5826677077.0
npm install @magic-ext/oauth@13.1.1-canary.606.5826677077.0
npm install @magic-ext/oidc@2.1.1-canary.606.5826677077.0
npm install @magic-ext/polkadot@14.1.1-canary.606.5826677077.0
npm install @magic-ext/react-native-bare-oauth@14.1.1-canary.606.5826677077.0
npm install @magic-ext/react-native-expo-oauth@14.1.1-canary.606.5826677077.0
npm install @magic-ext/solana@15.1.1-canary.606.5826677077.0
npm install @magic-ext/taquito@11.1.1-canary.606.5826677077.0
npm install @magic-ext/terra@11.1.1-canary.606.5826677077.0
npm install @magic-ext/tezos@14.1.1-canary.606.5826677077.0
npm install @magic-ext/webauthn@13.1.1-canary.606.5826677077.0
npm install @magic-ext/zilliqa@14.1.1-canary.606.5826677077.0
npm install @magic-sdk/commons@15.1.1-canary.606.5826677077.0
npm install @magic-sdk/pnp@13.1.1-canary.606.5826677077.0
npm install @magic-sdk/provider@19.1.1-canary.606.5826677077.0
npm install @magic-sdk/react-native-bare@20.1.1-canary.606.5826677077.0
npm install @magic-sdk/react-native-expo@20.1.1-canary.606.5826677077.0
npm install @magic-sdk/types@16.1.1-canary.606.5826677077.0
npm install magic-sdk@19.1.1-canary.606.5826677077.0
# or 
yarn add @magic-ext/algorand@14.1.1-canary.606.5826677077.0
yarn add @magic-ext/aptos@2.1.1-canary.606.5826677077.0
yarn add @magic-ext/auth@2.1.1-canary.606.5826677077.0
yarn add @magic-ext/avalanche@14.1.1-canary.606.5826677077.0
yarn add @magic-ext/bitcoin@14.1.1-canary.606.5826677077.0
yarn add @magic-ext/conflux@12.1.1-canary.606.5826677077.0
yarn add @magic-ext/cosmos@14.1.1-canary.606.5826677077.0
yarn add @magic-ext/ed25519@10.1.1-canary.606.5826677077.0
yarn add @magic-ext/flow@14.1.1-canary.606.5826677077.0
yarn add @magic-ext/gdkms@2.1.1-canary.606.5826677077.0
yarn add @magic-ext/harmony@14.2.1-canary.606.5826677077.0
yarn add @magic-ext/icon@14.1.1-canary.606.5826677077.0
yarn add @magic-ext/near@14.1.1-canary.606.5826677077.0
yarn add @magic-ext/oauth@13.1.1-canary.606.5826677077.0
yarn add @magic-ext/oidc@2.1.1-canary.606.5826677077.0
yarn add @magic-ext/polkadot@14.1.1-canary.606.5826677077.0
yarn add @magic-ext/react-native-bare-oauth@14.1.1-canary.606.5826677077.0
yarn add @magic-ext/react-native-expo-oauth@14.1.1-canary.606.5826677077.0
yarn add @magic-ext/solana@15.1.1-canary.606.5826677077.0
yarn add @magic-ext/taquito@11.1.1-canary.606.5826677077.0
yarn add @magic-ext/terra@11.1.1-canary.606.5826677077.0
yarn add @magic-ext/tezos@14.1.1-canary.606.5826677077.0
yarn add @magic-ext/webauthn@13.1.1-canary.606.5826677077.0
yarn add @magic-ext/zilliqa@14.1.1-canary.606.5826677077.0
yarn add @magic-sdk/commons@15.1.1-canary.606.5826677077.0
yarn add @magic-sdk/pnp@13.1.1-canary.606.5826677077.0
yarn add @magic-sdk/provider@19.1.1-canary.606.5826677077.0
yarn add @magic-sdk/react-native-bare@20.1.1-canary.606.5826677077.0
yarn add @magic-sdk/react-native-expo@20.1.1-canary.606.5826677077.0
yarn add @magic-sdk/types@16.1.1-canary.606.5826677077.0
yarn add magic-sdk@19.1.1-canary.606.5826677077.0

@octave08 octave08 requested a review from karljin August 10, 2023 22:21
@octave08 octave08 self-assigned this Aug 10, 2023
@octave08 octave08 added the patch Increment the patch version when merged label Aug 10, 2023
@octave08 octave08 added this pull request to the merge queue Aug 11, 2023
Merged via the queue into master with commit 8534da4 Aug 11, 2023
4 checks passed
@octave08 octave08 deleted the jayhwang-type-issues branch August 11, 2023 02:32
@Ariflo Ariflo added the released This issue/pull request has been released. label Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants