Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds template name to loginWithOTP and loginWithMagicLink #643

Merged
merged 6 commits into from Oct 18, 2023

Conversation

chrisdakin-magic
Copy link
Contributor

@chrisdakin-magic chrisdakin-magic commented Oct 10, 2023

πŸ“¦ Pull Request

Adds optional template name argument for use with new email customization feature

βœ… Fixed Issues

https://app.shortcut.com/magic-labs/story/87362/sdk-updates

🚨 Test instructions

[Describe any additional context required to test the PR/feature/bug fix.]

⚠️ Don't forget to add a semver label!

Please only add one label:

  • patch: Bug Fix?
  • minor: New Feature?
  • major: Breaking Change?
  • skip-release: It's unnecessary to publish this change.
πŸ“¦ Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @magic-ext/algorand@16.1.0-canary.643.6567644654.0
npm install @magic-ext/aptos@4.1.0-canary.643.6567644654.0
npm install @magic-ext/auth@4.1.0-canary.643.6567644654.0
npm install @magic-ext/avalanche@16.1.0-canary.643.6567644654.0
npm install @magic-ext/bitcoin@16.1.0-canary.643.6567644654.0
npm install @magic-ext/conflux@14.1.0-canary.643.6567644654.0
npm install @magic-ext/cosmos@16.1.0-canary.643.6567644654.0
npm install @magic-ext/ed25519@12.1.0-canary.643.6567644654.0
npm install @magic-ext/flow@16.1.0-canary.643.6567644654.0
npm install @magic-ext/gdkms@4.1.0-canary.643.6567644654.0
npm install @magic-ext/harmony@16.1.0-canary.643.6567644654.0
npm install @magic-ext/icon@16.1.0-canary.643.6567644654.0
npm install @magic-ext/near@16.1.0-canary.643.6567644654.0
npm install @magic-ext/oauth@15.1.0-canary.643.6567644654.0
npm install @magic-ext/oidc@4.1.0-canary.643.6567644654.0
npm install @magic-ext/polkadot@16.1.0-canary.643.6567644654.0
npm install @magic-ext/react-native-bare-oauth@16.1.0-canary.643.6567644654.0
npm install @magic-ext/react-native-expo-oauth@16.1.0-canary.643.6567644654.0
npm install @magic-ext/solana@17.1.0-canary.643.6567644654.0
npm install @magic-ext/taquito@13.1.0-canary.643.6567644654.0
npm install @magic-ext/terra@13.1.0-canary.643.6567644654.0
npm install @magic-ext/tezos@16.1.0-canary.643.6567644654.0
npm install @magic-ext/webauthn@15.1.0-canary.643.6567644654.0
npm install @magic-ext/zilliqa@16.1.0-canary.643.6567644654.0
npm install @magic-sdk/commons@17.1.0-canary.643.6567644654.0
npm install @magic-sdk/pnp@15.1.0-canary.643.6567644654.0
npm install @magic-sdk/provider@21.1.0-canary.643.6567644654.0
npm install @magic-sdk/react-native-bare@22.1.0-canary.643.6567644654.0
npm install @magic-sdk/react-native-expo@22.1.0-canary.643.6567644654.0
npm install @magic-sdk/types@17.1.0-canary.643.6567644654.0
npm install magic-sdk@21.1.0-canary.643.6567644654.0
# or 
yarn add @magic-ext/algorand@16.1.0-canary.643.6567644654.0
yarn add @magic-ext/aptos@4.1.0-canary.643.6567644654.0
yarn add @magic-ext/auth@4.1.0-canary.643.6567644654.0
yarn add @magic-ext/avalanche@16.1.0-canary.643.6567644654.0
yarn add @magic-ext/bitcoin@16.1.0-canary.643.6567644654.0
yarn add @magic-ext/conflux@14.1.0-canary.643.6567644654.0
yarn add @magic-ext/cosmos@16.1.0-canary.643.6567644654.0
yarn add @magic-ext/ed25519@12.1.0-canary.643.6567644654.0
yarn add @magic-ext/flow@16.1.0-canary.643.6567644654.0
yarn add @magic-ext/gdkms@4.1.0-canary.643.6567644654.0
yarn add @magic-ext/harmony@16.1.0-canary.643.6567644654.0
yarn add @magic-ext/icon@16.1.0-canary.643.6567644654.0
yarn add @magic-ext/near@16.1.0-canary.643.6567644654.0
yarn add @magic-ext/oauth@15.1.0-canary.643.6567644654.0
yarn add @magic-ext/oidc@4.1.0-canary.643.6567644654.0
yarn add @magic-ext/polkadot@16.1.0-canary.643.6567644654.0
yarn add @magic-ext/react-native-bare-oauth@16.1.0-canary.643.6567644654.0
yarn add @magic-ext/react-native-expo-oauth@16.1.0-canary.643.6567644654.0
yarn add @magic-ext/solana@17.1.0-canary.643.6567644654.0
yarn add @magic-ext/taquito@13.1.0-canary.643.6567644654.0
yarn add @magic-ext/terra@13.1.0-canary.643.6567644654.0
yarn add @magic-ext/tezos@16.1.0-canary.643.6567644654.0
yarn add @magic-ext/webauthn@15.1.0-canary.643.6567644654.0
yarn add @magic-ext/zilliqa@16.1.0-canary.643.6567644654.0
yarn add @magic-sdk/commons@17.1.0-canary.643.6567644654.0
yarn add @magic-sdk/pnp@15.1.0-canary.643.6567644654.0
yarn add @magic-sdk/provider@21.1.0-canary.643.6567644654.0
yarn add @magic-sdk/react-native-bare@22.1.0-canary.643.6567644654.0
yarn add @magic-sdk/react-native-expo@22.1.0-canary.643.6567644654.0
yarn add @magic-sdk/types@17.1.0-canary.643.6567644654.0
yarn add magic-sdk@21.1.0-canary.643.6567644654.0

@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #87362: SDK Updates.

@chrisdakin-magic chrisdakin-magic added the minor Increment the minor version when merged label Oct 10, 2023
@chrisdakin-magic chrisdakin-magic force-pushed the chrisdakin-sc-87362-sdk-updates branch 2 times, most recently from 089c4df to 34a260d Compare October 11, 2023 15:41
Ethella
Ethella previously approved these changes Oct 18, 2023
@chrisdakin-magic chrisdakin-magic added this pull request to the merge queue Oct 18, 2023
@chrisdakin-magic chrisdakin-magic self-assigned this Oct 18, 2023
Merged via the queue into master with commit e4b4b2f Oct 18, 2023
4 checks passed
@chrisdakin-magic chrisdakin-magic deleted the chrisdakin-sc-87362-sdk-updates branch October 18, 2023 23:50
@Ariflo Ariflo added the released This issue/pull request has been released. label Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Increment the minor version when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants