Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverts - Adds Response Time out Error to RN SDKs #725

Merged
merged 1 commit into from Mar 15, 2024

Conversation

Ariflo
Copy link
Contributor

@Ariflo Ariflo commented Mar 15, 2024

πŸ“¦ Pull Request

Reverts PR #721 which would throw a response timeout when a user's device connectivity is slow.

βœ… Fixed Issues

n/a

🚨 Test instructions

[Describe any additional context required to test the PR/feature/bug fix.]

⚠️ Don't forget to add a semver label!

Please 🚨 ONLY ADD ONE 🚨 of the following labels, failing to do so may lead to adverse versioning of your changes when published:

  • patch: Bug Fix?
  • minor: New Feature?
  • major: Breaking Change?
  • skip-release: It's unnecessary to publish this change.

Special Note

Please avoid adding any of the Priority labels as they conflict with the labels above ☝️

πŸ“¦ Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @magic-ext/algorand@21.1.0-canary.725.8302989803.0
npm install @magic-ext/aptos@9.1.0-canary.725.8302989803.0
npm install @magic-ext/avalanche@21.1.0-canary.725.8302989803.0
npm install @magic-ext/bitcoin@21.1.0-canary.725.8302989803.0
npm install @magic-ext/conflux@19.1.0-canary.725.8302989803.0
npm install @magic-ext/cosmos@21.1.0-canary.725.8302989803.0
npm install @magic-ext/ed25519@17.1.0-canary.725.8302989803.0
npm install @magic-ext/flow@21.1.0-canary.725.8302989803.0
npm install @magic-ext/gdkms@9.1.0-canary.725.8302989803.0
npm install @magic-ext/harmony@21.1.0-canary.725.8302989803.0
npm install @magic-ext/icon@21.1.0-canary.725.8302989803.0
npm install @magic-ext/near@21.1.0-canary.725.8302989803.0
npm install @magic-ext/oauth@20.1.0-canary.725.8302989803.0
npm install @magic-ext/oauth2@7.1.0-canary.725.8302989803.0
npm install @magic-ext/oidc@9.1.0-canary.725.8302989803.0
npm install @magic-ext/polkadot@21.1.0-canary.725.8302989803.0
npm install @magic-ext/react-native-bare-oauth@23.1.0-canary.725.8302989803.0
npm install @magic-ext/react-native-expo-oauth@23.1.0-canary.725.8302989803.0
npm install @magic-ext/solana@23.1.0-canary.725.8302989803.0
npm install @magic-ext/taquito@18.1.0-canary.725.8302989803.0
npm install @magic-ext/terra@18.1.0-canary.725.8302989803.0
npm install @magic-ext/tezos@21.1.0-canary.725.8302989803.0
npm install @magic-ext/webauthn@20.1.0-canary.725.8302989803.0
npm install @magic-ext/zilliqa@21.1.0-canary.725.8302989803.0
npm install @magic-sdk/commons@22.1.0-canary.725.8302989803.0
npm install @magic-sdk/pnp@20.1.0-canary.725.8302989803.0
npm install @magic-sdk/provider@26.1.0-canary.725.8302989803.0
npm install @magic-sdk/react-native-bare@27.1.0-canary.725.8302989803.0
npm install @magic-sdk/react-native-expo@27.1.0-canary.725.8302989803.0
npm install @magic-sdk/types@22.1.0-canary.725.8302989803.0
npm install magic-sdk@26.1.0-canary.725.8302989803.0
# or 
yarn add @magic-ext/algorand@21.1.0-canary.725.8302989803.0
yarn add @magic-ext/aptos@9.1.0-canary.725.8302989803.0
yarn add @magic-ext/avalanche@21.1.0-canary.725.8302989803.0
yarn add @magic-ext/bitcoin@21.1.0-canary.725.8302989803.0
yarn add @magic-ext/conflux@19.1.0-canary.725.8302989803.0
yarn add @magic-ext/cosmos@21.1.0-canary.725.8302989803.0
yarn add @magic-ext/ed25519@17.1.0-canary.725.8302989803.0
yarn add @magic-ext/flow@21.1.0-canary.725.8302989803.0
yarn add @magic-ext/gdkms@9.1.0-canary.725.8302989803.0
yarn add @magic-ext/harmony@21.1.0-canary.725.8302989803.0
yarn add @magic-ext/icon@21.1.0-canary.725.8302989803.0
yarn add @magic-ext/near@21.1.0-canary.725.8302989803.0
yarn add @magic-ext/oauth@20.1.0-canary.725.8302989803.0
yarn add @magic-ext/oauth2@7.1.0-canary.725.8302989803.0
yarn add @magic-ext/oidc@9.1.0-canary.725.8302989803.0
yarn add @magic-ext/polkadot@21.1.0-canary.725.8302989803.0
yarn add @magic-ext/react-native-bare-oauth@23.1.0-canary.725.8302989803.0
yarn add @magic-ext/react-native-expo-oauth@23.1.0-canary.725.8302989803.0
yarn add @magic-ext/solana@23.1.0-canary.725.8302989803.0
yarn add @magic-ext/taquito@18.1.0-canary.725.8302989803.0
yarn add @magic-ext/terra@18.1.0-canary.725.8302989803.0
yarn add @magic-ext/tezos@21.1.0-canary.725.8302989803.0
yarn add @magic-ext/webauthn@20.1.0-canary.725.8302989803.0
yarn add @magic-ext/zilliqa@21.1.0-canary.725.8302989803.0
yarn add @magic-sdk/commons@22.1.0-canary.725.8302989803.0
yarn add @magic-sdk/pnp@20.1.0-canary.725.8302989803.0
yarn add @magic-sdk/provider@26.1.0-canary.725.8302989803.0
yarn add @magic-sdk/react-native-bare@27.1.0-canary.725.8302989803.0
yarn add @magic-sdk/react-native-expo@27.1.0-canary.725.8302989803.0
yarn add @magic-sdk/types@22.1.0-canary.725.8302989803.0
yarn add magic-sdk@26.1.0-canary.725.8302989803.0

@Ariflo Ariflo added the minor Increment the minor version when merged label Mar 15, 2024
@Ariflo Ariflo self-assigned this Mar 15, 2024
@Ariflo Ariflo force-pushed the ariflo-pdeexp-649-revert-add-response-error branch from b633a0b to be42797 Compare March 15, 2024 22:22
@Ariflo Ariflo enabled auto-merge March 15, 2024 22:23
@Ariflo Ariflo added this pull request to the merge queue Mar 15, 2024
Merged via the queue into master with commit 0b13014 Mar 15, 2024
4 checks passed
@Ariflo Ariflo deleted the ariflo-pdeexp-649-revert-add-response-error branch March 15, 2024 22:33
@Ariflo Ariflo added the released This issue/pull request has been released. label Mar 15, 2024
@magiclabs magiclabs deleted a comment from Ariflo Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Increment the minor version when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants