Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape user names. #14

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Escape user names. #14

wants to merge 1 commit into from

Conversation

y120
Copy link

@y120 y120 commented Dec 29, 2017

Fixes #13

@coveralls
Copy link

Coverage Status

Coverage increased (+0.05%) to 83.819% when pulling c75b65c on y120:master into c631b40 on magicmark:master.

@magicmark
Copy link
Owner

magicmark commented Dec 30, 2017

Thanks for the PR!

Until https://github.com/benjamingr/RegExp.escape is a thing, would something like https://github.com/sindresorhus/escape-string-regexp work instead? then we could avoid adding our own escaping logic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants