Skip to content
This repository has been archived by the owner on Jun 7, 2020. It is now read-only.

Commit

Permalink
Fix test-net-server-on-fd-0 for windows by removing assert
Browse files Browse the repository at this point in the history
Rename to regression test for nodejsGH-746 as the fd 0 behavior was not what the
bug report was about.
  • Loading branch information
ry committed Aug 10, 2011
1 parent 501b0b9 commit b3bc009
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
1 change: 1 addition & 0 deletions Makefile
Expand Up @@ -185,6 +185,7 @@ UVTEST += simple/test-readdouble
UVTEST += simple/test-readfloat
UVTEST += simple/test-readint
UVTEST += simple/test-readuint
UVTEST += simple/test-regress-GH-746
UVTEST += simple/test-regress-GH-819
UVTEST += simple/test-regress-GH-897
UVTEST += simple/test-regression-object-prototype
Expand Down
Expand Up @@ -19,6 +19,9 @@
// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
// USE OR OTHER DEALINGS IN THE SOFTWARE.

// Just test that destroying stdin doesn't mess up listening on a server.
// This is a regression test for GH-746.

var common = require('../common');
var assert = require('assert');
var net = require('net');
Expand All @@ -36,7 +39,6 @@ var server = net.createServer(function(socket) {

server.listen(common.PORT, function() {
console.log('listening...');
assert.equal(server.fd, 0);

net.createConnection(common.PORT);
});
Expand Down

0 comments on commit b3bc009

Please sign in to comment.