Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

have symbol equal in the value property #13

Closed
wsf1991 opened this issue Jul 12, 2016 · 6 comments
Closed

have symbol equal in the value property #13

wsf1991 opened this issue Jul 12, 2016 · 6 comments
Labels

Comments

@wsf1991
Copy link

wsf1991 commented Jul 12, 2016

Hi I ran into this issue from eBay fabio, i want to set property 'registry.consul.register.tags'. i.e. "key1=val1" as one of the tag, but it has this kind of error:
[FATAL] 1.1.5. circular reference

is that a way to escape equal symbol. thanks

@magiconair
Copy link
Owner

The backslash should do the trick. Let me know if it doesn't then I'll have a look in one of the next days.

@magiconair
Copy link
Owner

Hmm, tested this with both fabio 1.1.5 and 1.1.6 and cannot reproduce this. However, I do noticed that the current 1.2 branch has a bug in that it does not register the tags at all.

# cat fabio.properties
...
registry.consul.register.tags = key1=val1
# ./fabio -cfg fabio.properties
...
2016/07/13 13:37:28 [INFO] consul: Registered fabio with tags "key1=val1"
...

@magiconair
Copy link
Owner

@wsf1991 : 1.2 does not have a bug. I just started it wrong. Can you provide a more detailed example, please? Otherwise, I'm going to close this.

@wsf1991
Copy link
Author

wsf1991 commented Jul 13, 2016

Hi Frank,

I pull Fabio master branch and set tags of Fabio registered in consul as key1=${env_var}, ...

Let me attach the error info later today. Thanks.

Regards,
Shifei Wu

在 2016年7月13日,上午5:14,Frank Schröder notifications@github.com 写道:

@wsf1991 : 1.2 does not have a bug. I just started it wrong. Can you provide a more detailed example, please? Otherwise, I'm going to close this.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

@magiconair
Copy link
Owner

ok, good since I can't reproduce that behavior either.

@magiconair
Copy link
Owner

I'll close this one for now. Please re-open if you have more information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants