Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WriteComment should ignore empty ones #3

Closed
emicklei opened this issue Apr 8, 2015 · 3 comments
Closed

WriteComment should ignore empty ones #3

emicklei opened this issue Apr 8, 2015 · 3 comments
Milestone

Comments

@emicklei
Copy link

emicklei commented Apr 8, 2015

If no comment was set for a key,value pair then I expect the WriteComment to not write the extra lines.

#
eddy.aq.concurrent.consumers = 10

#
eddy.aq.max.concurrent.consumers = 10

vs

eddy.aq.concurrent.consumers = 10
eddy.aq.max.concurrent.consumers = 10
@magiconair
Copy link
Owner

I've pushed the issue_3 branch which should fix that. Pls have a look.

@emicklei
Copy link
Author

emicklei commented Apr 9, 2015

thanks, will have a look tomorrow

On Wed, Apr 8, 2015 at 5:36 PM, Frank Schröder notifications@github.com
wrote:

I've pushed the issue_3 branch which should fix that. Pls have a look.


Reply to this email directly or view it on GitHub
#3 (comment).

^ Ernest Micklei

http://ernestmicklei.com

@magiconair
Copy link
Owner

Fixed in v1.5.2

@magiconair magiconair added this to the 1.5.2 milestone Oct 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants