Remove keys #6
Merged
Remove keys #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
July 28, 2015 12:32
Change-Id: Ifea9d67b6467f0373736d291a41d7d4685e697d7
Change-Id: Ie3dad6dfecbe7f07643fed1d4ef56dd840dc926a
Change-Id: I97325a64e5f8a5911e6251411931c39152d912da
|
I had initially removed the deletion of p.k, but later added it back, which is why the comment was off. Changed it now. |
|
Still not good since the go doc guidelines say that the comment should start with the function name :) So please change it to |
Change-Id: Ieb42988fe48cbc9e9e336edef4ebff3f2c2801ea
|
Tagged v1.5.5 with the change. Thx for the patch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you change the comment to "Delete removes the key..." then I'll merge it