-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature Request: Allow addition of multiple color variants at once in the mirrorful editor #119
Comments
Thanks for making the issue, I've been thinking about variants being auto-generated for the exact reason you describe... will do some thinking. Let me know if you have any other thoughts because I totally agree with you! |
Ah, yes agreed. Auto-generated variants seem like a great idea. I guess both of these things can be added. Once a user chooses a color:
Design-wise it can be simple for an initial phase - a radio button based block selector, where:
|
Could I make an alternate suggestion? If we had a pop-up menu for each variant box and the add variant box, you could perform tasks such as delete, set as base, or add default variants in one click without necessarily having to go through the modal, and have an edit option allowing access to the modal. The modal could then handle entry of multiple values in a list of desired... Thoughts? |
The UI needs to be updated for this one — I think this will be an awesome addition, but let me take a stab at it in Figma before we touch any code! |
https://www.loom.com/share/76ab642b459f4189acc21d2561ae71d7 |
Will leave to @Teddarific to chime in. I like your Loom Paul! |
Closed because we're moving to a model where you don't edit variants. |
Problem
Currently, if I add a new color to the theme, I have to add it's variants one by one using the mirrorful editor which is a tedious process.
Proposed Solution
Could a feature be added in the editor that allows the user to add multiple variants at once by passing the variants as key-value pairs in a javascript object?
The text was updated successfully, but these errors were encountered: