Adding automatic variants #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@karanvirsb are you saying you want to merge this into Paul's branch: #188 ? Or want to merge this into main? |
@alexdanilowicz It can be merged into the main if it seems good. I was just suggesting that it can also be done like this to @prichter. |
packages/mirrorful/editor/src/components/ColorPalette/EditColorModal.tsx
Outdated
Show resolved
Hide resolved
|
Oh nice! Love it @karanvirsb. Thanks for clarifying. I just QA-ed and watched your Loom. Really nice. Merging. |
This was referenced Mar 19, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to add to pull request #188. This adds a checkbox when adding a new colour to automatically generate variants.