Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polish empty state of color palette #24

Closed
Teddarific opened this issue Feb 22, 2023 · 8 comments
Closed

Polish empty state of color palette #24

Teddarific opened this issue Feb 22, 2023 · 8 comments
Assignees
Labels
good first issue Good for newcomers polish

Comments

@Teddarific
Copy link
Collaborator

Teddarific commented Feb 22, 2023

image

Let's add a skeleton state of what a color row typically looks like — basically an outline of what a color would look like.

@Teddarific Teddarific added polish good first issue Good for newcomers labels Feb 22, 2023
@prichter
Copy link
Contributor

prichter commented Mar 1, 2023

image

Would this be conceptually what we're looking for (with a bit more formatting for consistency, ie left justified)?

@Teddarific
Copy link
Collaborator Author

@prichter that's amazing! That's exactly what I was envisioning.

Let me know if you want to tackle this and I can assign you to this issue :)

@prichter
Copy link
Contributor

prichter commented Mar 1, 2023 via email

@alexdanilowicz
Copy link
Contributor

@prichter assigned!

@prichter
Copy link
Contributor

prichter commented Mar 2, 2023

image

Are we happy with this - click anywhere in the grey area to open dialogue?

@alexdanilowicz
Copy link
Contributor

alexdanilowicz commented Mar 2, 2023

I think the edit, delete, set as primary, set as secondary should not show if disabled! Otherwise too noisy and unclear what to click on.

@prichter
Copy link
Contributor

prichter commented Mar 2, 2023

More like this?
image
OR alternately, v-center of "Click to add" text:
image

@alexdanilowicz
Copy link
Contributor

I like the first option, not centered

Teddarific added a commit that referenced this issue Mar 8, 2023
* WIP

* Added new color skeleton component and added to ColorPaletteSection

* Fixed number type in for loop

* Updates on feedback from @alexdanilowicz

* Cleanup

* Update packages/mirrorful/editor/src/components/ColorPalette/AddColorSkeleton.tsx

* Update packages/mirrorful/editor/src/components/ColorPalette/AddColorSkeleton.tsx

---------

Co-authored-by: Paul Richter <paul@vtsw.com.au>
Co-authored-by: alexdanilowicz <alex.danilowicz@gmail.com>
Co-authored-by: Teddy Ni <teddyni19@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers polish
Projects
None yet
Development

No branches or pull requests

3 participants