-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Polish empty state of color palette #24
Labels
Comments
@prichter that's amazing! That's exactly what I was envisioning. Let me know if you want to tackle this and I can assign you to this issue :) |
Assign away!
…On Thu, 2 Mar 2023, 5:00 am Teddy Ni, ***@***.***> wrote:
@prichter <https://github.com/prichter> that's amazing! That's exactly
what I was envisioning.
Let me know if you want to tackle this and I can assign you to this issue
:)
—
Reply to this email directly, view it on GitHub
<#24 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAIJB2YICYBWXLTSZFKLXJLWZ6FDJANCNFSM6AAAAAAVEVOMUI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
@prichter assigned! |
I think the edit, delete, set as primary, set as secondary should not show if disabled! Otherwise too noisy and unclear what to click on. |
I like the first option, not centered |
Teddarific
added a commit
that referenced
this issue
Mar 8, 2023
* WIP * Added new color skeleton component and added to ColorPaletteSection * Fixed number type in for loop * Updates on feedback from @alexdanilowicz * Cleanup * Update packages/mirrorful/editor/src/components/ColorPalette/AddColorSkeleton.tsx * Update packages/mirrorful/editor/src/components/ColorPalette/AddColorSkeleton.tsx --------- Co-authored-by: Paul Richter <paul@vtsw.com.au> Co-authored-by: alexdanilowicz <alex.danilowicz@gmail.com> Co-authored-by: Teddy Ni <teddyni19@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Let's add a skeleton state of what a color row typically looks like — basically an outline of what a color would look like.
The text was updated successfully, but these errors were encountered: