Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to display married name of females in chart. #38

Closed
zeezhao opened this issue Aug 15, 2023 · 9 comments
Closed

Option to display married name of females in chart. #38

zeezhao opened this issue Aug 15, 2023 · 9 comments
Labels
enhancement New feature or request

Comments

@zeezhao
Copy link

zeezhao commented Aug 15, 2023

Is your feature request related to a problem? Please describe.
Sometimes, there is a need to show the married name of females in the chart, instead of birth name.

Describe the solution you'd like
It would be nice to have an option for instance in the "Show more options" section for "Display Married Names". Thanks

@magicsunday
Copy link
Owner

@zeezhao
Copy link
Author

zeezhao commented Aug 23, 2023

Hi - still not working for me. Please see:
#39 (comment)

edit:
I also did a quick test with "Show married names.", and it did not seem to work. Note that I recently fixed married names to use correct GED format, instead of the special field webtrees was using.

@magicsunday
Copy link
Owner

1.5.0 was corrupt, 1.5.1 should work now.

If it still not working, please provide me a working sample gedcom. In my tree I see the spouses with the married name (2 TYPE married).

@zeezhao
Copy link
Author

zeezhao commented Aug 23, 2023

Thanks. I did try it in 1.5.1 and same issue.
Unfortunately, I can't export the gedom but it is definitely using married name (2 TYPE married). Looking at raw gedcom, it is like:

1 NAME XXX /YYY/
....
1 NAME XXX /ZZZ/
2 TYPE MARRIED

But it displays "XXX YYY" always. Please is it possible the version you released is not taking into the account the flag? It gives me the same result whether "Show married names." is ticked or not.

@magicsunday
Copy link
Owner

magicsunday commented Aug 23, 2023

  • What type is the first name of the person?

Webtrees displays the first name from the gedcom as the primary name (except there is a different name matching the current locale):

// Generally, the first name is the primary one....
$this->getPrimaryName = 0;
// ...except when the language/name use different character sets
...

Without sample data, I can't reproduce your problem.

In my chart it's working as expected:

  • Default:
    grafik
  • Show married name
    grafik

@zeezhao
Copy link
Author

zeezhao commented Aug 23, 2023

Thanks for your help. The name type is "birth name".
edit: In my example, she is the descendant, so she is shown on top, so opposite to your example above. Her husband is show below.

@magicsunday
Copy link
Owner

Could you please check, if b288b75 fixes your problem?

@zeezhao
Copy link
Author

zeezhao commented Aug 23, 2023

Thank you - this seems to work too! I will do more testing to confirm.

@zeezhao
Copy link
Author

zeezhao commented Aug 24, 2023

This looks fine now. Thank you for your swift response and hard work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants