-
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1.1.0 - silhouette images are not displayed #13
Comments
Are the images of the individuals loaded correctly? Please try the latest version from master branch. I added some error logging to the image loading method. Do you get any errors in the console log? I do not get any errors in my Firefox and Edge. |
Which images? I don't use images.
I didn't test the initial release, only v1.1.0.
Done. Same problem.
Here's the content of the console log in Edge:
Here's the content of the console log in Firefox:
|
Strange. Maybe you can give me access to the site so that I can see for myself? |
I sent you an email with the link. |
I didn't get any email. |
Oops, I sent it to the wrong Ric... New mail sent to you. Anyway, I just installed a fresh webtrees as test, with only your Fan and Pedigree chart modules. And I found something interesting: photos are displayed correctly, silhouette images are not displayed! I've added two trees with a dummy info, one with and one without photos. I tested your Pedigree chart on both trees: tree without photos: I hope this will help to solve the problem. |
Ok. Seems a problem with the pretty URLs I dont use until now. There is also a bug in webtrees: fisharebest/webtrees#3665 preventing the display of SVG images. |
I changed the way returning the images from the module. Now its up to webtrees to return the correct mime type for SVG images in order to display them correctly.. |
With latest webtrees master and with latest master from this repo, the error should be fixed. |
Even with the last commit, I also encounter this bug. This was not happening with the code of my pull request. You must have changed something that you shouldn't have in the meantime ;) |
After investigation, it seems that in my case, it is 8237be7 which caused the problem. |
@TheDutchJewel Did it work for you? |
@06Games You have to use latest version from master-branch of webtrees as this contains the fix. fisharebest/webtrees@91694fa |
@magicsunday Yes, the latest version from the master-branch works fine with the latest webtrees master. Thanks for fixing! And thanks to the fix you mentioned, I can use your Pedigree chart in the stable webtrees version too! |
The silhouette images (webtrees\modules_v4\webtrees-pedigree-chart\resources\images) are not loaded in my browsers (latest versions of Edge and Firefox) on Win10 x64 20H2.
Edge shows a default picture:
![image](https://user-images.githubusercontent.com/46184729/104084739-0af7c680-524a-11eb-8514-21a5e14b56eb.png)
Firefox shows no picture:
![image](https://user-images.githubusercontent.com/46184729/104084743-1519c500-524a-11eb-8012-fac5778ae92f.png)
Any idea how to fix this?
The text was updated successfully, but these errors were encountered: