-
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Click on individuals support #11
Conversation
The individual selection by the form uses AJAX again for consistency I had to remove the name of the selected individual from the title because it was not updated
Thanks for your contribution. For now I only picked the 820c1d3 commit as I'm unsure in which direction the development will lead and if clicking on the root person should lead to its individual page. Updating the chart while clicking on a person does not update the chart title, maybe this should collapse the subtree instead. |
Regarding the orientation of development, I see two possibilities:
As for the title, I had to remove the name of the selected person from it in order to overcome the problem of updating. Although I don't find it disturbing, I understand that it can be inconvenient to lose this information from the title |
Also, I would like to do another pull request to add a French translation but I did not fully understand how files with an |
I use PoEdit to edit the language files. https://poedit.net/ You only edit the .po files. The .mo files are the created binary files. |
I added you commits but did some small changes to it. |
This pull request allows you to navigate in the tree by clicking on individuals or to open its page if the individual is at the root of the tree