Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default parameters for guests in a config panel #58

Closed
wants to merge 4 commits into from

Conversation

papjul
Copy link
Contributor

@papjul papjul commented Mar 20, 2023

Currently, default parameters are in constants.
I wanted to control it more easily from the admin, so I created this control panel.

I will let you review it and let me know if you want to integrate it, before I start working on the descendants chart the same way.

@magicsunday
Copy link
Owner

Hi. I'm sorry it took a while. First of all, thank you for your contribution.

I checked your changes. These do not currently work as the form configuration is already stored in the browser's LocalStorage, i.e. if you change the number of generations from the standard 4 to 6, for example, this is stored in LocalStorage. If you call up the page again, the selection of the generations is now initialized with 6. The pre-assignment from the module does not apply.

grafik

Seen in this light, an additional configuration module in the admin area doesn't really seem necessary to me.

@papjul
Copy link
Contributor Author

papjul commented Apr 23, 2023

This config panel was added as a default (for guests who don't have a local storage yet).

When you first visit the website, this would display in a specific layout with a specific number of generations.
Currently, the default layout is hardcoded in constants, this just makes it configurable.

Of course, when the user decides to change the default parameters, this becomes specific, which is the expected behavior.

I will rename the name of the pull request to clarify.

My use case was that I preferred to have my guests seeing my charts from bottom to top by default (which is a more common layout here in France, than left to right).

@papjul papjul changed the title Add config panel Add default parameters for guests in a config panel Apr 23, 2023
@papjul
Copy link
Contributor Author

papjul commented Oct 20, 2023

Is there anything else I can do to help with this feature? Thank you!

@magicsunday
Copy link
Owner

I merged it into the current branch 2.1. Sorry it took so long. Thank you for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants